Skip to content

🐛 fix list_users_in_group introduced in previous PR #8249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 22, 2025
Merged

🐛 fix list_users_in_group introduced in previous PR #8249

merged 6 commits into from
Aug 22, 2025

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Aug 22, 2025

What do these changes do?

  • 🐛 fix list_users_in_group introduced in previous PR (I merged it by mistake, before introducing test, this PR fix the listing and introduces unit test)

Related issue/s

How to test

Dev-ops

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review August 22, 2025 09:38
@matusdrobuliak66 matusdrobuliak66 self-assigned this Aug 22, 2025
@matusdrobuliak66 matusdrobuliak66 added bug buggy, it does not work as expected a:webserver webserver's codebase. Assigning the area is particularly useful for bugs labels Aug 22, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Voyager milestone Aug 22, 2025
pcrespov
pcrespov approved these changes Aug 22, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@codecov
Copy link

codecov bot commented Aug 22, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.34%. Comparing base (c1c5d79) to head (fb42095).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8249      +/-   ##
==========================================
- Coverage   87.86%   85.34%   -2.53%     
==========================================
  Files        1917      743    -1174     
  Lines       74171    34365   -39806     
  Branches     1301      175    -1126     
==========================================
- Hits        65171    29329   -35842     
+ Misses       8609     4979    -3630     
+ Partials      391       57     -334
Flag Coverage Δ
integrationtests 63.90% <0.00%> (+0.01%) ⬆️
unittests 87.32% <0.00%> (+0.77%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.95% <ø> (-8.02%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.18% <ø> (-12.75%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 87.13% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.06% <0.00%> (+0.03%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c5d79...fb42095. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for fb42095.

🟢 All jobs passed!

But CI Insights is watching 👀

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) August 22, 2025 10:29
@matusdrobuliak66
Copy link
Collaborator Author

matusdrobuliak66 commented Aug 22, 2025

@mergify queue

@matusdrobuliak66 matusdrobuliak66 added the 🤖-automerge marks PR as ready to be merged for Mergify label Aug 22, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 22, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis

@matusdrobuliak66 matusdrobuliak66 merged commit 8f96782 into ITISFoundation:master Aug 22, 2025
91 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 2, 2025
Closed
61 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 18, 2025
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@odeimaiz odeimaiz Awaiting requested review from odeimaiz

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs bug buggy, it does not work as expected

Projects

None yet

Milestone

Voyager

Development

Successfully merging this pull request may close these issues.

3 participants

@matusdrobuliak66 @GitHK @pcrespov